Change in libosmocore[master]: iuup: Fix decoding of 1byte-length subflow size fields
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/26786 ) Change subject: iuup: Fix decoding of 1byte-length subflow size fields ...................................................................... iuup: Fix decoding of 1byte-length subflow size fields Change-Id: I78ae9e7d46d0725ddec05e004ae22ee5da738162 --- M src/gsm/iuup.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/86/26786/1 diff --git a/src/gsm/iuup.c b/src/gsm/iuup.c index b838dc6..f526382 100644 --- a/src/gsm/iuup.c +++ b/src/gsm/iuup.c @@ -527,7 +527,7 @@ } else { uint8_t *subflow_size = ihdr_rfci->subflow_length; for (i = 0; i < ihdr->num_subflows_per_rfci; i++) { - iui->config.subflow_sizes[ihdr_rfci->rfci][i] = osmo_load16be(subflow_size); + iui->config.subflow_sizes[ihdr_rfci->rfci][i] = *subflow_size; subflow_size++; } } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I78ae9e7d46d0725ddec05e004ae22ee5da738162 Gerrit-Change-Number: 26786 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-MessageType: newchange
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26786 ) Change subject: iuup: Fix decoding of 1byte-length subflow size fields ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I78ae9e7d46d0725ddec05e004ae22ee5da738162 Gerrit-Change-Number: 26786 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Wed, 05 Jan 2022 20:14:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/26786 ) Change subject: iuup: Fix decoding of 1byte-length subflow size fields ...................................................................... iuup: Fix decoding of 1byte-length subflow size fields Change-Id: I78ae9e7d46d0725ddec05e004ae22ee5da738162 --- M src/gsm/iuup.c 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/gsm/iuup.c b/src/gsm/iuup.c index b838dc6..f526382 100644 --- a/src/gsm/iuup.c +++ b/src/gsm/iuup.c @@ -527,7 +527,7 @@ } else { uint8_t *subflow_size = ihdr_rfci->subflow_length; for (i = 0; i < ihdr->num_subflows_per_rfci; i++) { - iui->config.subflow_sizes[ihdr_rfci->rfci][i] = osmo_load16be(subflow_size); + iui->config.subflow_sizes[ihdr_rfci->rfci][i] = *subflow_size; subflow_size++; } } -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/26786 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I78ae9e7d46d0725ddec05e004ae22ee5da738162 Gerrit-Change-Number: 26786 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged
participants (2)
-
laforge -
pespin