dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31791 ) Change subject: timeslot_fsm: fix PDCH activation ...................................................................... timeslot_fsm: fix PDCH activation All non ericsson BTSs we support use a BTS co-located PCU, so we must not depend on a PCU connection in those cases. Related: OS#5943 Fixes: ecf825dc ("pcu_sock: activate/deactivate PDCH on pcu reconnect") Change-Id: I296dfacb451d7b9b5ef1cec940bc1a577f3c43ad --- M src/osmo-bsc/timeslot_fsm.c 1 file changed, 15 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified osmith: Looks good to me, approved diff --git a/src/osmo-bsc/timeslot_fsm.c b/src/osmo-bsc/timeslot_fsm.c index 16d7360..aa5e0db 100644 --- a/src/osmo-bsc/timeslot_fsm.c +++ b/src/osmo-bsc/timeslot_fsm.c @@ -341,7 +341,7 @@ return; } - if (!pcu_connected(bts)) { + if (is_ericsson_bts(bts) && !pcu_connected(bts)) { LOG_TS(ts, LOGL_DEBUG, "PCU not connected: not activating PDCH.\n"); return; } -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31791 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I296dfacb451d7b9b5ef1cec940bc1a577f3c43ad Gerrit-Change-Number: 31791 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-MessageType: merged