Attention is currently required from: neels. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/32019 ) Change subject: unique_ids_test.c: fix coverity ASSERT_SIDE_EFFECT ...................................................................... Patch Set 2: Code-Review+1 (1 comment) Patchset: PS2: I think it's fine to assume that assert()s are never disabled for tests, so Coverity can be ignored in this specific case. But I am not against this patch either, so +1. -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/32019 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: I4490a62f444d5048779c9b184b5f580cecd4c149 Gerrit-Change-Number: 32019 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Comment-Date: Wed, 22 Mar 2023 20:15:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment