Attention is currently required from: pespin, daniel.
dexter has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-hnbgw/+/27320 )
Change subject: mgw_fsm: release call when FSM is not created
......................................................................
Patch Set 1:
(1 comment)
File src/osmo-hnbgw/mgw_fsm.c:
https://gerrit.osmocom.org/c/osmo-hnbgw/+/27320/comment/206b7d3e_281d0509
PS1, Line 724: tx_release_req(map);
Shouldn't we instead return a RAB assignment
response with a failed list?
We could, but then the formatting of the message would
be more difficult. If we would have gone for multiple-rab support I would say we
definitely do that, but here I think its better to kill everything with by sending an
IuRelease. (I don't think this is a spec violation.)
--
To view, visit
https://gerrit.osmocom.org/c/osmo-hnbgw/+/27320
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I1904f7e95d86bbcecee14f8721bd4075d0e33ab4
Gerrit-Change-Number: 27320
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <pmaier(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 24 Feb 2022 14:37:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: daniel <dwillmann(a)sysmocom.de>
Gerrit-MessageType: comment