Attention is currently required from: fixeria, osmith.
Jenkins Builder has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email )
Change subject: nokia: add support for Flexi Multiradio ......................................................................
Patch Set 2:
(5 comments)
File src/osmo-bsc/bts_nokia_site.c:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/2a82c0ba_94532e8f?usp=... : PS2, Line 1778: It is also possible to configure the BTS without a reset, but in this case please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/b4927bdb_3b9f02ed?usp=... : PS2, Line 1779: the BTS does not accept any changes in configuration - therefore, the mode please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/6dc20b80_5f1f37fb?usp=... : PS2, Line 1780: of skipping BSC-driven BTS reset is only for use during osmo-bsc development, please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/7d417717_b60d8b4e?usp=... : PS2, Line 1781: when the developer-operator resets the BTS manually before each test run. please, no spaces at the start of a line
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/6b42baee_ecedf0fb?usp=... : PS2, Line 1785: static int abis_nm_rcvmsg_fom(struct e1inp_sign_link *sign_link, Avoid multiple line dereference - prefer 'run.static'