laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34267?usp=email ) Change subject: NAS_Templates: fix ts_NAS_GUTI ...................................................................... NAS_Templates: fix ts_NAS_GUTI The template ts_NAS_GUTI permutates the MCC/MNC digits in a weird way, which seems to map to a format that is not used anywhere else. Also the template is not used anywhere yet. Let's not permutate the MCC/MNC digit, instead let's put a comment that makes clear which format has to be used. Change-Id: I9546993987b873e8ae921664238b234608e37bba Related: OS#5760 --- M library/NAS_Templates.ttcn 1 file changed, 23 insertions(+), 4 deletions(-) Approvals: laforge: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/library/NAS_Templates.ttcn b/library/NAS_Templates.ttcn index f819862..bbe7237 100644 --- a/library/NAS_Templates.ttcn +++ b/library/NAS_Templates.ttcn @@ -111,13 +111,15 @@ template (value) GUTI ts_NAS_GUTI(hexstring mcc_mnc, OCT2 mmegi, OCT1 mmec, OCT4 tmsi) := { oddevenIndicator := '0'B, spare := '1111'B, - /* mcc_mnc specified in format 262f42 */ + /* use the mcc_mnc format as specified in 3GPP TS 24.301, figure 9.9.3.12.1. + * Example: mcc=262, mnc=42 => 262f42. + * mcc=001, mnc=01 => 001f01. */ mccDigit1 := mcc_mnc[0], mccDigit2 := mcc_mnc[1], mccDigit3 := mcc_mnc[2], - mncDigit3 := mcc_mnc[5], - mncDigit1 := mcc_mnc[3], - mncDigit2 := mcc_mnc[4], + mncDigit3 := mcc_mnc[3], + mncDigit1 := mcc_mnc[4], + mncDigit2 := mcc_mnc[5], mMEGI := mmegi, mMEC := mmec, mTMSI := tmsi -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34267?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I9546993987b873e8ae921664238b234608e37bba Gerrit-Change-Number: 34267 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged