keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28420 ) Change subject: Improve parsing of om2000 fault reports ...................................................................... Improve parsing of om2000 fault reports Fault Reports are commonly oberved with a TLV id 0xd2 as are reports with up to 20 TLVs. Let's not have these cause logging at level ERROR. Closes: OS#5593 Change-Id: Ibe0b38835362c59d1576a206b2f64cea4427295f --- M src/osmo-bsc/abis_om2000.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/20/28420/1 diff --git a/src/osmo-bsc/abis_om2000.c b/src/osmo-bsc/abis_om2000.c index 1deab13..84fb7ac 100644 --- a/src/osmo-bsc/abis_om2000.c +++ b/src/osmo-bsc/abis_om2000.c @@ -310,6 +310,7 @@ OM2K_DEI_MAX_ALLOWED_POWER = 0xa9, OM2K_DEI_MAX_ALLOWED_NUM_TRXCS = 0xaa, OM2K_DEI_MCTR_FEAT_STATUS_BMAP = 0xab, + OM2K_DEI_SEEN_UNKNOWN_D2 = 0xd2, }; enum abis_om2k_mostate { @@ -388,6 +389,7 @@ [OM2K_DEI_FS_OFFSET] = { TLV_TYPE_FIXED, 5 }, [OM2K_DEI_EXT_COND_MAP_2_EXT] = { TLV_TYPE_FIXED, 4 }, [OM2K_DEI_TSS_MO_STATE] = { TLV_TYPE_FIXED, 4 }, + [OM2K_DEI_SEEN_UNKNOWN_D2] = { TLV_TYPE_FIXED, 6 }, }, }; @@ -2882,7 +2884,7 @@ /* Bail if an the maximum number of TLV fields * have been parsed */ - if (tlv_count >= 11) { + if (tlv_count >= 20) { LOGP(DNM, LOGL_ERROR, "Rx MO=%s Fault Report: too many tlv elements!\n", abis_om2k_mo_name(mo)); return; -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/28420 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ibe0b38835362c59d1576a206b2f64cea4427295f Gerrit-Change-Number: 28420 Gerrit-PatchSet: 1 Gerrit-Owner: keith <keith@rhizomatica.org> Gerrit-MessageType: newchange