Attention is currently required from: pespin, fixeria. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741 to look at the new patch set (#3). Change subject: build: fix linking gen__pfcp_ies_auto to use build-tree libosmo-gtlv ...................................................................... build: fix linking gen__pfcp_ies_auto to use build-tree libosmo-gtlv Resolve some confusion in src/libosmo-pfcp/Makefile.am: It builds - the libosmo-pfcp library. - the gen__pfcp_ies_auto tool to be used at build time. The library has its own LDFLAGS directive, so it does not used the global AM_LDFLAGS. So there is no point to have AM_LDFLAGS, and then additional gen__pfcp_ies_auto__LDADD, just have a gen__pfcp_ies_auto__LDFLAGS. Put the locally built dependency libosmo-gtlv.la first in this LDFLAGS, so that libtool takes it from the build tree, not a system installed lib (if any). Still keep the AM_CFLAGS, needed for #include paths for building libosmo-pfcp objects. However, no vty #includes are used, so drop LIBOSMOVTY_CFLAGS. Related: OS#5942 Change-Id: I2e92238b214d8e79bab1095d6093139bad05bc66 --- M src/libosmo-pfcp/Makefile.am 1 file changed, 31 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/libosmo-pfcp refs/changes/41/31741/3 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/31741 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I2e92238b214d8e79bab1095d6093139bad05bc66 Gerrit-Change-Number: 31741 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: newpatchset