Attention is currently required from: jolly, laforge.

pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email )

Change subject: Add DSCP configuration support for server transport role ......................................................................

Patch Set 4:

(3 comments)

File src/ss7_xua_srv_vty.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/d855b1a2_441d37... : PS3, Line 152: "ip-dscp " IP_DSCP_RANGE_STR,

Done

Please also change the names of the functions and commands inside DEFUN_ATTR to adapt to the new name.

File src/ss7_xua_srv_vty.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/1e025753_5d309d... : PS4, Line 167: NO_STR "Reset IP DSCP of Listener to default\n", The NO_STR usually means we write the next param the same way as in the positive case iirc.

https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/ca6be987_1207f6... : PS4, Line 256: vty_out(vty, " ip-dscp %u%s", xs->cfg.ip_dscp, VTY_NEWLINE); You missed updating the name here.