Attention is currently required from: laforge, pespin, daniel. arehbein has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33652 ) Change subject: ipa: Add segmentation callback ...................................................................... Patch Set 5: (3 comments) File include/osmocom/netif/ipa.h: https://gerrit.osmocom.org/c/libosmo-netif/+/33652/comment/6a49898d_bb42ab28 PS4, Line 27: #define msgb_ipa_proto(__x) OSMO_MSGB_IPA_CB(__x)->proto

osmo_msgb_ipa_cb_proto […] I put `osmo_ipa_msgb_cb*`, because it's in `ipa.h` and not in `msgb.h` and because to me it seems less confusing to stick to filename prefixes.

File src/ipa.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33652/comment/80f13ef4_74d76a85 PS2, Line 378: MSG_CB_IPA_PROTO_EXT_IS_SET_OFFSET

We wouldn't need the IS_SET flag anyway, I'd expect proto_ext to only have a meaning if proto is IPA […] Concerning the idea of a struct, I deliberately did not go for a struct in order to avoid violating the strict aliasing rule, since `msg->cb` is an array of `unsigned long`. Seems like we don't care/looks like we use `-fno-strict-aliasing` everywhere anyways, so I'll keep that in mind. At least now I know where we stand on this

https://gerrit.osmocom.org/c/libosmo-netif/+/33652/comment/639e4653_5142065a PS2, Line 432: /* Below: Helper functions for addition of send_ipa functionality in later commit */

Iirc the idea was to introduce ipa_check_pull_headers() AND use it in the segmentation_cb(). […] Done

-- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33652 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I87ef4c7023126b783dd79e7ed47be31e1b76f975 Gerrit-Change-Number: 33652 Gerrit-PatchSet: 5 Gerrit-Owner: arehbein <arehbein@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Comment-Date: Sat, 29 Jul 2023 18:57:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: arehbein <arehbein@sysmocom.de> Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Comment-In-Reply-To: daniel <dwillmann@sysmocom.de> Gerrit-MessageType: comment