Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by daniel. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39704?usp=email ) Change subject: sgsn_libgtp: Update struct pdp_t with RAT type when receiving an SGSN ctx ...................................................................... Patch Set 1: (1 comment) File src/sgsn/sgsn_libgtp.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/39704/comment/1fe73a88_2ef26a8e?usp... : PS1, Line 231: lib_pdp->rattype.v[0] = 2; a comment regarding what 1 and 2 mean here would be welcome, or even using some enum or define... -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/39704?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I998ba8cbd586bc19894e157bfa281963bf27de6e Gerrit-Change-Number: 39704 Gerrit-PatchSet: 1 Gerrit-Owner: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: lynxis lazus <lynxis@fe80.eu> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Wed, 05 Mar 2025 18:19:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No