Attention is currently required from: pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35176?usp=email ) Change subject: mgcp_network: Allow rx of IuUP in loopback mode with set rem IP address and unset rem port ...................................................................... Patch Set 2: (3 comments) Patchset: PS2: IMHO we should abandon this and merge https://gerrit.osmocom.org/c/osmo-mgw/+/35205 instead (details below) File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/c/osmo-mgw/+/35176/comment/9a5fdc3d_77b828d4 PS2, Line 866: HACK: for IuUP, we want to reply with an IuUP Initialization ACK upon the first RTP : * messag

This code was only active in LOOPBACK mode; since patch [1] we no longer send CRCX in LOOPBACK from […] Tests show these things:

(1) I'm partly wrong about loopback: osmo-msc sends CRCX in recvonly mode, but osmo-hnbgw still sends CRCX in loopback mode. That explains why this patch cares about LOOPBACK. Nevertheless, we should get rid of the need for LOOPBACK mode for IUFP: The IuUP Init procedure is one layer below the RTP loopback/send/recv behavior. (2) I did need a patch for osmo-mgw to successfully establish a 3G call, because indeed the IuUP Initialization message is refused with a message like "Rx RTP from 127.0.0.6, but remote address not set: dropping early media" Submitting the patch as I6c365559a7bd197349f0ea99f7a13b56a4bb580b https://gerrit.osmocom.org/c/osmo-mgw/+/35205 https://gerrit.osmocom.org/c/osmo-mgw/+/35176/comment/35e13006_767d29c1 PS2, Line 876: return 0;

it's like this, right? […] Done

-- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35176?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: Idd833997abce46886e9664505b2776fa5dadc8db Gerrit-Change-Number: 35176 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Mon, 04 Dec 2023 03:45:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofmeyr@sysmocom.de> Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment