Attention is currently required from: jolly, neels, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/33500 ) Change subject: ASCI: Allow usage of rtp_stream with other FSM ...................................................................... Patch Set 6: Code-Review+1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-msc/+/33500/comment/643c349b_9b784c00 PS6, Line 13: Drop the unused parent_call_leg member. This is probably another patch. File include/osmocom/msc/rtp_stream.h: https://gerrit.osmocom.org/c/osmo-msc/+/33500/comment/cc460e46_de812f53 PS6, Line 29: uint32_t avail_event; what about naming all of them ev_* or event_*. We usually use the prefix in all event enums, and it makes it easier to understand when reading it's an event imho. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/33500 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I0991927b6d00da08dfd455980645e68281a73a9e Gerrit-Change-Number: 33500 Gerrit-PatchSet: 6 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Wed, 05 Jul 2023 10:54:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment