Attention is currently required from: laforge, pespin.

jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807?usp=email )

Change subject: Add DSCP configuration support for server transport role ......................................................................

Patch Set 4:

(2 comments)

File src/ss7_xua_srv.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/8b958d04_db3579... : PS3, Line 408: osmo_stream_srv_link_set_ip_dscp(xs->server, xs->cfg.ip_dscp);

xs->server may actually be NULL, so you need to early return in that case.

It can't be NULL, when called from VTY, because the L_CS7_XUA_NODE, from which it is called, is only entered when the server has been created. But in case this function is used somewhere else in the future, I added a check.

File src/ss7_xua_srv_vty.c:

https://gerrit.osmocom.org/c/libosmo-sigtran/+/42807/comment/08c01b52_9f2c55... : PS3, Line 152: "ip-dscp " IP_DSCP_RANGE_STR,

As mentioned in IM, this should be "init-ip-dscp".

Done