Attention is currently required from: jolly, neels. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/34985?usp=email ) Change subject: LAPD: Add support for RTS based polling and T200 ...................................................................... Patch Set 9: (2 comments) File src/isdn/lapd_core.c: https://gerrit.osmocom.org/c/libosmocore/+/34985/comment/956b985c_79614f74 PS9, Line 1939: if ((dl->lapd_flags & LAPD_F_RTS) && !llist_empty(&dl->tx_queue)) { This looks a bit weird. You return here if !llist_empty() (and RTS), but in lapd_ph_rts_ind() you call this function only if llist_empty(). I might be missing something, I'm not really familiar with this code. https://gerrit.osmocom.org/c/libosmocore/+/34985/comment/a2231539_1c716b12 PS9, Line 1945: next_frame: Irrelevant for this patch, but this label really should be unindented. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/34985?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ib961b5a44911b99b0487641533301749c0286995 Gerrit-Change-Number: 34985 Gerrit-PatchSet: 9 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: neels <nhofmeyr@sysmocom.de> Gerrit-CC: daniel <dwillmann@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Comment-Date: Fri, 24 Nov 2023 10:09:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment