Attention is currently required from: laforge.
fixeria has posted comments on this change by laforge. ( https://gerrit.osmocom.org/c/pysim/+/37848?usp=email )
Change subject: pySim.esim.saip: maintain a parsed fileystem hierarchy ......................................................................
Patch Set 1:
(2 comments)
File pySim/esim/saip/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/37848/comment/3def40f0_c6efb131?usp=ema... : PS1, Line 100: def __init__(self, pename: str, l: Optional[List[Tuple]] = None, template: : Not really related to this patch, but looks like you want to use `**kwargs` here to pass optional parameters. Also, you're missing to add a docstring for the new `name` param.
https://gerrit.osmocom.org/c/pysim/+/37848/comment/42c781f6_2fe4ea56?usp=ema... : PS1, Line 139: if False: Intentional?
-
fixeria