Attention is currently required from: fixeria, jolly, pespin.
Hello Jenkins Builder, fixeria, jolly, osmith,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/c/libosmo-sigtran/+/43753?usp=email
to look at the new patch set (#4).
The following approvals got outdated and were removed: Code-Review+1 by jolly, Verified+1 by Jenkins Builder
Change subject: ss7_asp_peer: Improvements in ss7_asp_peer_snprintf() ......................................................................
ss7_asp_peer: Improvements in ss7_asp_peer_snprintf()
Convert it to osmo_strbuf, which simplifies the logic of the function, taking osmo_multiaddr_ip_and_port_snprintf() as reference to implement it. As a result: * Single IPv6 addresses now get properly enclosed in [], eg: "[::]:2905". * We avoid passing NULL to snprintf(), which is unspecified on some platforms.
Change-Id: I115951627adb0c6778a9a36159237c3eea130300 --- M src/ss7_asp_peer.c M tests/ss7/ss7_test.err M tests/ss7/ss7_test.ok 3 files changed, 31 insertions(+), 30 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sigtran refs/changes/53/43753/4