Attention is currently required from: dexter.

laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/33124 )

Change subject: Switch from pycryptodome to pycryptodomex
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

File README.md:

https://gerrit.osmocom.org/c/pysim/+/33124/comment/0da3c4f9_0fa8be0d 
PS1, Line 57: 	python3-pycryptodome \
> I don't understand this, isn't the pycryptodome dependency already satisfied when pycryptodomex is i […]
* I typically prefer install distribution packages rater than pip packages, and as pycryptodome is packaged in Debian for many years, I added it there

* as I wrote in the commit log, the debian package python3-pycryptodome actually contains pycryptodomex, not pycryptodome.



-- 
To view, visit https://gerrit.osmocom.org/c/pysim/+/33124
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I04daed01f51f9702595ef9f9e0d7fcdf1e4adb62
Gerrit-Change-Number: 33124
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <laforge@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pmaier@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: dexter <pmaier@sysmocom.de>
Gerrit-Comment-Date: Fri, 02 Jun 2023 08:23:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: dexter <pmaier@sysmocom.de>
Gerrit-MessageType: comment