pespin has submitted this change. ( https://gerrit.osmocom.org/c/libosmo-sigtran/+/39702?usp=email ) Change subject: xua_asp_fsm: Avoid sending NOTIFY in ASP role ...................................................................... xua_asp_fsm: Avoid sending NOTIFY in ASP role Fixes: f2e324e2f82efc93fd2a1124fa216d680659ed40 Change-Id: I48848a69cabbd1c7279344dc8b2b7e2927894d26 --- M src/xua_asp_fsm.c 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Jenkins Builder: Verified daniel: Looks good to me, but someone else must approve pespin: Looks good to me, approved diff --git a/src/xua_asp_fsm.c b/src/xua_asp_fsm.c index 9ad9dce..ec149d1 100644 --- a/src/xua_asp_fsm.c +++ b/src/xua_asp_fsm.c @@ -481,14 +481,17 @@ static void xua_asp_fsm_inactive_onenter(struct osmo_fsm_inst *fi, uint32_t prev_state) { struct xua_asp_fsm_priv *xafp = fi->priv; + struct osmo_ss7_asp *asp = xafp->asp; /* RFC4666 4.3.4.5: "When an ASP moves from ASP-DOWN to ASP-INACTIVE within a * particular AS, a Notify message SHOULD be sent, by the ASP-UP receptor, * after sending the ASP-UP-ACK, in order to inform the ASP of the current AS * state." + * NOTIFY is only transmitted by roles SG and IPSP. */ struct xua_as_event_asp_inactive_ind_pars pars = { - .asp = xafp->asp, - .asp_requires_notify = (prev_state == XUA_ASP_S_DOWN), + .asp = asp, + .asp_requires_notify = (asp->cfg.role != OSMO_SS7_ASP_ROLE_ASP) && + (prev_state == XUA_ASP_S_DOWN), }; dispatch_to_all_as(fi, XUA_ASPAS_ASP_INACTIVE_IND, &pars); } -- To view, visit https://gerrit.osmocom.org/c/libosmo-sigtran/+/39702?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmo-sigtran Gerrit-Branch: master Gerrit-Change-Id: I48848a69cabbd1c7279344dc8b2b7e2927894d26 Gerrit-Change-Number: 39702 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de>