Attention is currently required from: laforge, pespin, tnt. jolly has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/osmo-e1d/+/41139?usp=email ) Change subject: Add Channel-Associated Signalling (CAS) support ...................................................................... Patch Set 5: (3 comments) File include/osmocom/e1d/proto_clnt.h: https://gerrit.osmocom.org/c/osmo-e1d/+/41139/comment/0446c2af_24f76a8c?usp=... : PS3, Line 47: int osmo_e1dp_client_set_cas(struct osmo_e1dp_client *clnt, uint8_t intf, uint8_t line, uint8_t ts,

Update TODO-RELEASE with an entry stating a new API is added. Done

File src/ctl.c: https://gerrit.osmocom.org/c/osmo-e1d/+/41139/comment/dd19aa58_707cb04f?usp=... : PS3, Line 382: if (line->ts[16].mode == E1_TS_MODE_CAS && hdr->ts == 16) {

maybe not important, but sounds safer first checking hdr->ts and then accessing line->ts. Done

File src/mux_demux.c: https://gerrit.osmocom.org/c/osmo-e1d/+/41139/comment/d7c3b518_f25b3b9c?usp=... : PS3, Line 397: if (!line->cas.rx.buf_valid[line->cas.rx.frame_count + 14] ||

this looks to me like the event is signalled at a per-line level, and not at a per-timeslot level. […] I do not need to iterate over all time slots, because the CAS event is already triggered in the receive path. When the first CAS bits or any different CAS bit is received for a specific time slot, osmo_e1dp_server_event() is called.

All e1d clients will receive all events. (similar to E1 line signals) In libosmo-abis the event will be filtered and only forwarded to the applications that use the line. (See e1d_client_event_cb @ libosmo-abis) All applications that may have one or more time slots on an E1 line must receive CAS events of all time slots, because the application may use (open/close) a time slot depending on the received CAS events. This is more efficient than having all idle channels open all the time. libosmo-abis does not know in advance which time slots will be used by which application. The application must ignore events for time slots that will not be used. -- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/41139?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: Ib4f5e6ef02c9b0d1eec2a86d9c48376112805972 Gerrit-Change-Number: 41139 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: tnt <tnt@246tNt.com> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: tnt <tnt@246tNt.com> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Sun, 01 Feb 2026 12:46:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: pespin <pespin@sysmocom.de>