Attention is currently required from: daniel, lynxis lazus. fixeria has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37867?usp=email ) Change subject: Refactor diffing same GMM messages ...................................................................... Patch Set 15: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-sgsn/+/37867/comment/be19f081_f61eaf54?usp... : PS15, Line 9: isn'nt typo: isn't File src/sgsn/gprs_gmm.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/37867/comment/885cad83_f2335cd8?usp... : PS15, Line 1432: Checks if two attach request contain the IEs and IE values This needs to be updated. https://gerrit.osmocom.org/c/osmo-sgsn/+/37867/comment/2fa1e281_be90b6eb?usp... : PS15, Line 1435: return 1/-1 following memcmp() This is not true. From `man memcmp`: ``` The memcmp() function returns an integer less than, equal to, or greater than zero ... ``` Now it's a positive or negative integer on mismatch. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37867?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: Ie698d3a6894a5796663c22c8bfd12b47acda57e6 Gerrit-Change-Number: 37867 Gerrit-PatchSet: 15 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Wed, 09 Oct 2024 19:39:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No