Attention is currently required from: falconia.
laforge has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42725?usp=email )
Change subject: nokia cosmetic: add bts_is_insite() function
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
I think I'd prefer something like @if (nokia_bts_type(bts) == NOKIA_BTS_INSITE)@ as it would scale more logically with further BTS models. But that's not a blocker, just a comment.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/42725?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: I44bbcd79d9741f1df280b6b2391f04f754598035
Gerrit-Change-Number: 42725
Gerrit-PatchSet: 1
Gerrit-Owner: falconia
falcon@freecalypso.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Attention: falconia
falcon@freecalypso.org
Gerrit-Comment-Date: Tue, 05 May 2026 07:45:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes