laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/41936?usp=email )

Change subject: bts: f_est_dchan(): populate UL SACCH cache ......................................................................

bts: f_est_dchan(): populate UL SACCH cache

This ensures that UL SACCH blocks always contain the expected content and a proper L1 SACCH header, rather than the dummy measurement report hard-coded in trxcon/firmware. As a result, the BTS receives consistent and realistic UL SACCH from the very beginning.

Change-Id: I4781fe7539e64e77d594e84f905646c127f46b64 Related: OS#6933 --- M bts/BTS_Tests.ttcn 1 file changed, 3 insertions(+), 9 deletions(-)

Approvals: pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified laforge: Looks good to me, approved

diff --git a/bts/BTS_Tests.ttcn b/bts/BTS_Tests.ttcn index 32061e5..5275cff 100644 --- a/bts/BTS_Tests.ttcn +++ b/bts/BTS_Tests.ttcn @@ -2529,6 +2529,9 @@ ch_desc := valueof(ts_ChanDescH0(g_pars.chan_nr, trx_pars.arfcn, g_pars.tsc)); }

+ /* Populate UL SACCH cache with a Measurement Report */ + f_send_meas_rep(ts_MeasurementResults); + /* enable dedicated mode */ f_l1ctl_est_dchan(L1CTL, g_pars);

@@ -3899,9 +3902,6 @@ g_pars.l1_pars.ms_actual_ta := ta_to_test; f_L1CTL_PARAM(L1CTL, g_pars.l1_pars.ms_actual_ta, g_pars.l1_pars.ms_power_level); - /* tell trxcon to use a given TA in UL SACCH blocks - * this is achieved by populating UL SACCH cache before doing f_l1ctl_est_dchan() */ - f_send_meas_rep(ts_MeasurementResults);

f_est_dchan(more_ies :={valueof(t_RSL_IE(RSL_IE_TIMING_ADVANCE, RSL_IE_Body:{timing_adv := ta_to_test}))} );

@@ -8197,9 +8197,6 @@ /* Ensure that 'rx-current' equals 'rx-target' */ f_trxc_fake_rssi(mp_uplink_power_target);

- /* Populate SACCH cache with a Measurement Report */ - f_send_meas_rep(ts_MeasurementResults); - /* Establish a dedicated channel */ f_est_dchan(more_ies := valueof(ies));

@@ -8261,9 +8258,6 @@ /* Ensure that 'rx-current' equals 'rx-target' */ f_trxc_fake_rssi(mp_uplink_power_target);

- /* Populate SACCH cache with a Measurement Report */ - f_send_meas_rep(ts_MeasurementResults); - /* Establish a dedicated channel */ f_est_dchan(more_ies := valueof(ies));