laforge has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30373 ) Change subject: pcu: TC_mt_ping_pong*: Fix race condition waiting for first DL data after X2002 ...................................................................... pcu: TC_mt_ping_pong*: Fix race condition waiting for first DL data after X2002 Since recently osmo-pcu arms the X2002 in a more fitting place (later, when paging.cnf is received from osmo-bts over PCUIF). Since we use same X2002 value in TTCN3 to wait for the timer to trigger, in the past it was always fine (the X2002 at osmo-pcu always already had triggered before the one in ttcn3 after receiving the ImmAss). However, now the timer is roughly set at the same time in both places (ttcn3 and osmo-pcu) and hence there may be race conditions where we request a DL data block before the X2002 triggered at osmo-pcu, in which case we receive a DL dummy block because the TBF is not yet in the FLOW state Change-Id: Icc94eb0544226facddcd65be65a8a41bcfc662cc --- M pcu/PCU_Tests.ttcn 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved diff --git a/pcu/PCU_Tests.ttcn b/pcu/PCU_Tests.ttcn index 936f101..4b909c7 100644 --- a/pcu/PCU_Tests.ttcn +++ b/pcu/PCU_Tests.ttcn @@ -2573,7 +2573,10 @@ /* Wait timer X2002 and DL block is available after CCCH IMM ASS: */ f_sleep(X2002); - f_rx_rlcmac_dl_block_exp_data(dl_block, dl_fn, data, 0, exp_cs_mcs); + /* Skip potential dummy blocks before X2002 triggers at PCU after us: */ + dl_fn := f_rx_rlcmac_dl_block_skip_dummy(dl_block, max_dummy := 10); + + f_rlcmac_dl_block_exp_data(dl_block, data, 0, exp_cs_mcs); /* ACK the DL block, and request UL TBF at the same time */ f_dltbf_ack_block(ms.dl_tbf, dl_block, '1'B); -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/30373 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Icc94eb0544226facddcd65be65a8a41bcfc662cc Gerrit-Change-Number: 30373 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-MessageType: merged