[S] Change in simtrace2[master]: firmware: Add talloc_report_buf() encode the allocation by bits
Attention is currently required from: laforge, pespin.
lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/simtrace2/+/43004?usp=email )
Change subject: firmware: Add talloc_report_buf() encode the allocation by bits ......................................................................
Patch Set 6:
(2 comments)
File firmware/libcommon/source/pseudo_talloc.c:
https://gerrit.osmocom.org/c/simtrace2/+/43004/comment/94c32fb7_096c3084?usp... : PS6, Line 85: msgb_inuse_too_ig
spelling? too_ig -> too_big ?
Done
https://gerrit.osmocom.org/c/simtrace2/+/43004/comment/405dd4a4_83c83bda?usp... : PS6, Line 101: return bitoff + 1;
are you sure the +1 in here is correct?
+1 is always correct. if bitpos == 7 we might waste a byte.
-
lynxis lazus