Attention is currently required from: laforge, tnt. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-e1d/+/35557?usp=email ) Change subject: Add new protocol command and events for Sa bits and line states ...................................................................... Patch Set 2: (2 comments) File include/osmocom/e1d/proto.h: https://gerrit.osmocom.org/c/osmo-e1d/+/35557/comment/0db4c6c8_0679e6d7 PS1, Line 83: E1DP_EVT_SABITS = 0x7f,

any specific reason to go with 0x7f rather than the next free +1, i.e. […] If new line events are added in the future, I don't want to have Sa-bits event between line events.

File src/proto.c: https://gerrit.osmocom.org/c/osmo-e1d/+/35557/comment/d74259ac_3abdb1ce PS1, Line 44: { E1DP_CMD_SABITS, "E1DP_CMD_SABITS" },

Remove E1DP_ prefix for consistency Done

-- To view, visit https://gerrit.osmocom.org/c/osmo-e1d/+/35557?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-e1d Gerrit-Branch: master Gerrit-Change-Id: I4c20ec19fa3d9cce82c8199b38d173aa272fb07d Gerrit-Change-Number: 35557 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: tnt <tnt@246tNt.com> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: tnt <tnt@246tNt.com> Gerrit-Comment-Date: Mon, 15 Jan 2024 18:26:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: laforge <laforge@osmocom.org> Comment-In-Reply-To: tnt <tnt@246tNt.com> Gerrit-MessageType: comment