laforge has submitted this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/28485 )
Change subject: nacc_fsm: Fix uninitialized plmn.mnc_3_digits parsing CTRL neigh
resolution cmd
......................................................................
nacc_fsm: Fix uninitialized plmn.mnc_3_digits parsing CTRL neigh resolution cmd
Fixes: Coverity CID#272987
Change-Id: I819bdb0cc126113542547e9c397673a2dee0f168
---
M src/nacc_fsm.c
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, but someone else must approve
laforge: Looks good to me, approved
diff --git a/src/nacc_fsm.c b/src/nacc_fsm.c
index c049f60..2c321c7 100644
--- a/src/nacc_fsm.c
+++ b/src/nacc_fsm.c
@@ -799,6 +799,7 @@
if (!(tok = strtok_r(NULL, "-", &saveptr)))
goto free_ret;
cgi_ps.rai.lac.plmn.mnc = atoi(tok);
+ cgi_ps.rai.lac.plmn.mnc_3_digits = strlen(tok) > 2;
if (!(tok = strtok_r(NULL, "-", &saveptr)))
goto free_ret;
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/28485
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I819bdb0cc126113542547e9c397673a2dee0f168
Gerrit-Change-Number: 28485
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-MessageType: merged