Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31771 ) Change subject: error log: osmo_sock_init2_multiaddr() v4/v6 mix ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/core/socket.c: https://gerrit.osmocom.org/c/libosmocore/+/31771/comment/5db6749f_45906121 PS1, Line 776: ((flags & OSMO_SOCK_F_BIND) && (flags & OSMO_SOCK_F_CONNECT)) && : !addrinfo_has_in6addr_any((const struct addrinfo **)res_loc, local_hosts_cnt) && : (loc_has_v4addr != rem_has_v4addr || loc_has_v6addr != rem_has_v6addr)) { general note about this (unrelated to the patch): It appeasr to ignore IPv4-mapped IPv6 addresses (http://mars.tekkom.dk/w/index.php/IPv4-Mapped_IPv6_Address) So technical I'd assume the IP stack of any OS would be able to establish a connection between something like 1.2.3.4 and ::ffff:5.6.7.8 which our code would probably consider being v4 on one side and v6 on the other not really critical -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31771 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0fd12b08e0788ce3af6dc519ff8c82ad196a115f Gerrit-Change-Number: 31771 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofmeyr@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: neels <nhofmeyr@sysmocom.de> Gerrit-Comment-Date: Thu, 09 Mar 2023 09:22:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment