Attention is currently required from: laforge, msuraev. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/30301 ) Change subject: osmo-stat-dummy: add rate counters and statsd tester ...................................................................... Patch Set 19: (3 comments) Patchset: PS19: Since this util has several files, better create a utils/osmo-stat-dummy/ directory to have everything there. File utils/Makefile.am: https://gerrit.osmocom.org/c/libosmocore/+/30301/comment/445e2d85_ca42cae4 PS19, Line 37: osmo_stat_dummy_CFLAGS = $(TALLOC_CFLAGS) aren't you missing several CFLAGS here for libosmocore? File utils/README: https://gerrit.osmocom.org/c/libosmocore/+/30301/comment/dfbd59d9_a7d80134 PS19, Line 1: * osmo-stat-dummy: urility for rate counter and statsd testing utility. Add a better header? use markdown? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/30301 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ibd8b17aa3ba9ceb527c6231310f01d736fb542a7 Gerrit-Change-Number: 30301 Gerrit-PatchSet: 19 Gerrit-Owner: msuraev <msuraev@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: msuraev <msuraev@sysmocom.de> Gerrit-Comment-Date: Mon, 05 Dec 2022 10:24:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment