Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/43205?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: osmo-smdpp: derive the Profile Metadata from the Profile ...................................................................... osmo-smdpp: derive the Profile Metadata from the Profile Only the ICCID came from the Profile. The SPN was hardcoded, the profileName was the MatchingID, and the profileClass was always 'operational'. SGP.22 section 2.4.5.3 does not allow that class for a Profile that uses the USIM test algorithm. Add ProfileMetadata.from_pes() to read these fields from the Profile. If the Profile has no EF.SPN, the SPN is now empty. An LPA shows a Profile that is marked 'test' only in Device Test Mode. The code also tested the MatchingID twice. Remove the second test. Change-Id: Ie24dd5ac0ef541c1899dd923a9db568209bbfa62 --- M osmo-smdpp.py M pySim/esim/es8p.py M tests/unittests/test_esim_saip.py 3 files changed, 72 insertions(+), 16 deletions(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/05/43205/2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/43205?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ie24dd5ac0ef541c1899dd923a9db568209bbfa62 Gerrit-Change-Number: 43205 Gerrit-PatchSet: 2 Gerrit-Owner: Johannes Waigel <johannes@waigel.me> Gerrit-Reviewer: Jenkins Builder