Attention is currently required from: Hoernchen, laforge. Hello Hoernchen, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/42204?usp=email to look at the new patch set (#2). Change subject: checkpatch.conf: lint more code ...................................................................... checkpatch.conf: lint more code The current linter configuration misses to find lots of formatting errors as we've seen here: https://gerrit.osmocom.org/c/osmo-trx/+/42198/comments/f8f1b5a2_3c7e1389 Fix this by not excluding files where the linter generates false positives. But instead ignoring specific rules that generate these false positives (mostly related to this being a C++ code base). The following rules are now ignored: * SPACING Fails on: std::vector<std::string> With: ERROR:SPACING: spaces required around that '<' (ctx:VxV) ERROR:SPACING: spaces required around that '>' (ctx:VxW) * FUNCTION_ARGUMENTS Fails on: ScopedLock lock(mLock); With: WARNING:FUNCTION_ARGUMENTS: function definition argument 'mLock' should also have an identifier name * INDENTED_LABEL Fails on: private: protected: With: WARNING:INDENTED_LABEL: labels should not be indented * NEW_TYPEDEFS Fails on: typedef std::map<K,D*> Map; With: WARNING:NEW_TYPEDEFS: do not add new typedefs With the new config, the linter only complains about the following things across the existing code, which seem to be legitimate linting problems (and if not, can be ignored as well): BRACES_NOT_NECESSARY, CODE_INDENT, LEADING_SPACE, MULTISTATEMENT_MACRO_USE_DO_WHILE, OPEN_BRACE, POINTER_LOCATION, PRINTF_I_OSMO, SINGLE_STATEMENT_DO_WHILE_MACRO, SPACE_BEFORE_TAB, STATIC_CONST_CHAR_ARRAY, TABSTOP, TRAILING_WHITESPACE Change-Id: I0df5b6f2f0bf1469a80a1f5859809c30f523f683 --- M .checkpatch.conf 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/04/42204/2 -- To view, visit https://gerrit.osmocom.org/c/osmo-trx/+/42204?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: newpatchset Gerrit-Project: osmo-trx Gerrit-Branch: master Gerrit-Change-Id: I0df5b6f2f0bf1469a80a1f5859809c30f523f683 Gerrit-Change-Number: 42204 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <osmith@sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: Jenkins Builder Gerrit-Attention: Hoernchen <ewild@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org>