Attention is currently required from: falconia, fixeria.
osmith has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email )
Change subject: nokia: add support for Flexi Multiradio
......................................................................
Patch Set 3:
(1 comment)
File src/osmo-bsc/bts_nokia_site.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/42712/comment/bf064a8d_dc1fb9a1?usp=... :
PS1, Line 1785: static int abis_nm_rcvmsg_fom(struct e1inp_sign_link *sign_link,
Strangely enough, the current revision of this patch passes the linter, even though the linked osmo- […]
ah, the linter didn't recognize the lines without * as comments (it just does some basic regex logic, it can't parse the code into an abstract syntax tree, but it works well enough in most cases) and didn't parse the " test run." and "static int" parts correctly.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bsc/+/42712?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Change-Id: Icd429552c3b5e90d6c5d3ae5f52afd6550e3cebc
Gerrit-Change-Number: 42712
Gerrit-PatchSet: 3
Gerrit-Owner: falconia
falcon@freecalypso.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria
vyanitskiy@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-CC: osmith
osmith@sysmocom.de
Gerrit-Attention: falconia
falcon@freecalypso.org
Gerrit-Attention: fixeria
vyanitskiy@sysmocom.de
Gerrit-Comment-Date: Thu, 30 Apr 2026 08:40:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith
osmith@sysmocom.de
Comment-In-Reply-To: falconia
falcon@freecalypso.org
Comment-In-Reply-To: fixeria
vyanitskiy@sysmocom.de