Attention is currently required from: daniel, lynxis lazus. pespin has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37865?usp=email ) Change subject: Routing Area: Remove cells when NSEI becomes unavailable ...................................................................... Patch Set 5: Code-Review-1 (2 comments) File src/sgsn/gprs_routing_area.c: https://gerrit.osmocom.org/c/osmo-sgsn/+/37865/comment/aac5edc4_e6c13be7?usp... : PS5, Line 289: llist_for_each_entry_safe(ra, ra2, &sgsn_ra_ctx->ras, list) {

space required before the open parenthesis '('

This one needs to be fixed. This is a for, not a function, we use a space. https://gerrit.osmocom.org/c/osmo-sgsn/+/37865/comment/dcb5aee8_96ef0504?usp... : PS5, Line 290: llist_for_each_entry_safe(cell, cell2, &ra->cells, list) {

space required before the open parenthesis '('

Please fix. -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37865?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I9f0386d9eb7f0cabaf0fde45f8e78b4ea28c67c5 Gerrit-Change-Number: 37865 Gerrit-PatchSet: 5 Gerrit-Owner: lynxis lazus <lynxis@fe80.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillmann@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: daniel <dwillmann@sysmocom.de> Gerrit-Attention: lynxis lazus <lynxis@fe80.eu> Gerrit-Comment-Date: Tue, 20 Aug 2024 18:50:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes