Attention is currently required from: lynxis lazus.
Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/39562?usp=email )
Change subject: Rework SGSN code to use new libvlr code ......................................................................
Patch Set 9:
(4 comments)
File src/sgsn/gprs_gmm.c:
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/155525c0_7e6bd946?usp... : PS9, Line 1289: if (!mmctx->attach_rau.rau_fsm || rc != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/857d0dfe_7a9089cd?usp... : PS9, Line 1553: if (TLVP_PRESENT(&req.tlv, GSM48_IE_GMM_PTMSI_TYPE)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/cbc1acb7_49e1f96c?usp... : PS9, Line 1811: if (!mmctx->attach_rau.rau_fsm || rc != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID ): https://gerrit.osmocom.org/c/osmo-sgsn/+/39562/comment/1792883b_df9c7eb9?usp... : PS9, Line 1964: trailing whitespace
-
Jenkins Builder