arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/31533 )
Change subject: common: Have PCU socket connection use osmo_wqueue
......................................................................
Patch Set 13:
(1 comment)
Patchset:
PS2:
BTW, once merged, remember to submit a similar fix in
osmo-bsc.git (it also has a pcu_sock). […]
I reran the setup two times, respectively
pausing either osmo-bsc or osmo-pcu, and didn't encounter any increase in memory usage
(only had to adapt the osmo-bsc config to add `role sg` as well as `sctp-role client` in
order to get it to start, and osmo-pcu was complaining about an outdated PCU IF, but I
suppose that didn't break the PCU IF communication).
I also vaguely remember mentioning making a similar change to the other components using
the PCU IF, with the response being that we would be using osmo io soon anyways, thus
eliminating the need for osmo_wqueues doing the processing.
So I don't know if anything should be done/what should be done.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/31533
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ia6e61dda4b3cd4bba76e6acb7771d70335062fe1
Gerrit-Change-Number: 31533
Gerrit-PatchSet: 13
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Sun, 02 Jul 2023 21:45:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment