Change in pysim[master]: filesystem: use correct AID for applications found by probing
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/pysim/+/26767 ) Change subject: filesystem: use correct AID for applications found by probing ...................................................................... filesystem: use correct AID for applications found by probing When printing applications found by probing for a specific AID, then the wrong variable is used to print the AID. Change-Id: I3d5ec28e46fe00c0d793a1d9ef0a0e0900649a4d --- M pySim/filesystem.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/67/26767/1 diff --git a/pySim/filesystem.py b/pySim/filesystem.py index c706131..dfe1677 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -1115,7 +1115,7 @@ for f in set(apps_profile) - set(apps_taken): data, sw = self.card.select_adf_by_aid(f.aid) if sw == "9000": - print(" %s: %s" % (f.name, a)) + print(" %s: %s" % (f.name, f.aid)) apps_taken.append(f) return apps_taken -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3d5ec28e46fe00c0d793a1d9ef0a0e0900649a4d Gerrit-Change-Number: 26767 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-MessageType: newchange
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26767 ) Change subject: filesystem: use correct AID for applications found by probing ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3d5ec28e46fe00c0d793a1d9ef0a0e0900649a4d Gerrit-Change-Number: 26767 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Wed, 05 Jan 2022 06:42:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/26767 ) Change subject: filesystem: use correct AID for applications found by probing ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3d5ec28e46fe00c0d793a1d9ef0a0e0900649a4d Gerrit-Change-Number: 26767 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Comment-Date: Wed, 05 Jan 2022 09:44:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/26767 ) Change subject: filesystem: use correct AID for applications found by probing ...................................................................... filesystem: use correct AID for applications found by probing When printing applications found by probing for a specific AID, then the wrong variable is used to print the AID. Change-Id: I3d5ec28e46fe00c0d793a1d9ef0a0e0900649a4d --- M pySim/filesystem.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Jenkins Builder: Verified fixeria: Looks good to me, approved laforge: Looks good to me, approved diff --git a/pySim/filesystem.py b/pySim/filesystem.py index c706131..dfe1677 100644 --- a/pySim/filesystem.py +++ b/pySim/filesystem.py @@ -1115,7 +1115,7 @@ for f in set(apps_profile) - set(apps_taken): data, sw = self.card.select_adf_by_aid(f.aid) if sw == "9000": - print(" %s: %s" % (f.name, a)) + print(" %s: %s" % (f.name, f.aid)) apps_taken.append(f) return apps_taken -- To view, visit https://gerrit.osmocom.org/c/pysim/+/26767 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I3d5ec28e46fe00c0d793a1d9ef0a0e0900649a4d Gerrit-Change-Number: 26767 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-MessageType: merged
participants (3)
-
dexter -
fixeria -
laforge