Attention is currently required from: arehbein, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/33193 ) Change subject: Add osmo_io support to osmo_stream_cli and osmo_stream_srv ...................................................................... Patch Set 4: (2 comments) File src/stream.c: https://gerrit.osmocom.org/c/libosmo-netif/+/33193/comment/a3410ae0_c942c2d5 PS3, Line 1360: #define OSMO_STREAM_SRV_F_FLUSH_DESTROY (1 << 0)

Why is this code block moved from below to to here? […] I was squashing https://gerrit.osmocom.org/c/libosmo-netif/+/33195 into this commit, but I guess you're right and I didn't notice that it mixes osmo_stream_srv and srv_link

https://gerrit.osmocom.org/c/libosmo-netif/+/33193/comment/40d6aa9b_75734748 PS3, Line 1610: rc = conn->read_cb(conn);

Mayeb the read_cb rename can be done in a separate prior patch to simplify this one. Ack

-- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/33193 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: I2f52c7107c392b6f4b0bf2a84f8c873c084a200c Gerrit-Change-Number: 33193 Gerrit-PatchSet: 4 Gerrit-Owner: arehbein <arehbein@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: daniel <dwillmann@sysmocom.de> Gerrit-CC: laforge <laforge@osmocom.org> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: arehbein <arehbein@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 08 Jun 2023 13:01:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment