Change in osmo-iuh[master]: iu_client: Fix incorrect access to null pointer
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26898 ) Change subject: iu_client: Fix incorrect access to null pointer ...................................................................... iu_client: Fix incorrect access to null pointer Fixes: adec82f3b1c725e8a70d327b9592940fbdeaaff7 Closes: Coverity CID#243765 Related: OS#5398 Change-Id: Ib435b053241c294619c3478fe3b6450d8d181888 --- M src/iu_client.c 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-iuh refs/changes/98/26898/1 diff --git a/src/iu_client.c b/src/iu_client.c index 7d29903..077ac27 100644 --- a/src/iu_client.c +++ b/src/iu_client.c @@ -462,8 +462,7 @@ struct osmo_scu_prim *prim; if (!uectx) { - LOGPIU(LOGL_ERROR, "Discarding to-be-transmitted L3 Message as RANAP DT with unset dst SCCP conn_id!\n", - uectx->conn_id); + LOGPIU(LOGL_ERROR, "Discarding to-be-transmitted L3 Message as RANAP DT with unset dst SCCP conn_id!\n"); return -ENOTCONN; } -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26898 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ib435b053241c294619c3478fe3b6450d8d181888 Gerrit-Change-Number: 26898 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-MessageType: newchange
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26898 ) Change subject: iu_client: Fix incorrect access to null pointer ...................................................................... Patch Set 1: I'll merge this myself since it's an stupid trivial error I introduced in a recent patch while attempting the same null pointer access... -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26898 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ib435b053241c294619c3478fe3b6450d8d181888 Gerrit-Change-Number: 26898 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Thu, 13 Jan 2022 09:43:14 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26898 ) Change subject: iu_client: Fix incorrect access to null pointer ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26898 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ib435b053241c294619c3478fe3b6450d8d181888 Gerrit-Change-Number: 26898 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 13 Jan 2022 09:50:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
pespin has submitted this change. ( https://gerrit.osmocom.org/c/osmo-iuh/+/26898 ) Change subject: iu_client: Fix incorrect access to null pointer ...................................................................... iu_client: Fix incorrect access to null pointer Fixes: adec82f3b1c725e8a70d327b9592940fbdeaaff7 Closes: Coverity CID#243765 Related: OS#5398 Change-Id: Ib435b053241c294619c3478fe3b6450d8d181888 --- M src/iu_client.c 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Jenkins Builder: Verified pespin: Looks good to me, approved diff --git a/src/iu_client.c b/src/iu_client.c index 7d29903..077ac27 100644 --- a/src/iu_client.c +++ b/src/iu_client.c @@ -462,8 +462,7 @@ struct osmo_scu_prim *prim; if (!uectx) { - LOGPIU(LOGL_ERROR, "Discarding to-be-transmitted L3 Message as RANAP DT with unset dst SCCP conn_id!\n", - uectx->conn_id); + LOGPIU(LOGL_ERROR, "Discarding to-be-transmitted L3 Message as RANAP DT with unset dst SCCP conn_id!\n"); return -ENOTCONN; } -- To view, visit https://gerrit.osmocom.org/c/osmo-iuh/+/26898 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Change-Id: Ib435b053241c294619c3478fe3b6450d8d181888 Gerrit-Change-Number: 26898 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged
participants (1)
-
pespin