falconia has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/41668?usp=email ) Change subject: gsm/rsl: add definition for TFO transparent container IE ...................................................................... gsm/rsl: add definition for TFO transparent container IE 3GPP Rel5 version of TS 48.058 RSL spec introduced a new IE named "TFO transparent container". By this point in GSM/3GPP evolutionary history, Abis was already treated as a de facto proprietary interface, and the spec is silent regarding the exact bit content of this new IE. (See vague description in section 9.3.59.) However, this IE was added at the same time as Generic Config Frames for TFO (TS 28.062 Annex H), hence one can reasonably infer that this IE is intended to transport the content of these GCFs between the BTS and the BSC, with the BTS relaying, mostly transparently, between the BSC and the TRAU channel. Add RSL_IE_TFO_XPAR_CONT definition, to make it possible to add this IE to CHAN ACTIV and MODE MODIFY commands (and thus enable TFO-AMR on those E1 BTS models that implement Rel5 version thereof) and to parse BTS response and notification messages that may also contain this IE. Change-Id: Ic6839827fb2bf8e401476af1d7907b577e5f094d --- M include/osmocom/gsm/protocol/gsm_08_58.h M src/gsm/rsl.c 2 files changed, 2 insertions(+), 0 deletions(-) Approvals: fixeria: Looks good to me, but someone else must approve pespin: Looks good to me, approved Jenkins Builder: Verified laforge: Looks good to me, but someone else must approve diff --git a/include/osmocom/gsm/protocol/gsm_08_58.h b/include/osmocom/gsm/protocol/gsm_08_58.h index 13e84ba..fe41237 100644 --- a/include/osmocom/gsm/protocol/gsm_08_58.h +++ b/include/osmocom/gsm/protocol/gsm_08_58.h @@ -358,6 +358,7 @@ RSL_IE_RTD, RSL_IE_TFO_STATUS, RSL_IE_LLP_APDU, + RSL_IE_TFO_XPAR_CONT, /* Siemens vendor-specific */ RSL_IE_SIEMENS_MRPCI = 0x40, RSL_IE_SIEMENS_PREF_AREA_TYPE = 0x43, diff --git a/src/gsm/rsl.c b/src/gsm/rsl.c index c7d69a1..b394a34 100644 --- a/src/gsm/rsl.c +++ b/src/gsm/rsl.c @@ -121,6 +121,7 @@ [RSL_IE_RTD] = { TLV_TYPE_TV }, [RSL_IE_TFO_STATUS] = { TLV_TYPE_TV }, [RSL_IE_LLP_APDU] = { TLV_TYPE_TLV }, + [RSL_IE_TFO_XPAR_CONT] = { TLV_TYPE_TLV }, [RSL_IE_SIEMENS_MRPCI] = { TLV_TYPE_TV }, [RSL_IE_OSMO_REP_ACCH_CAP] = { TLV_TYPE_TLV }, [RSL_IE_OSMO_TRAINING_SEQUENCE] = { TLV_TYPE_TLV }, -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/41668?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ic6839827fb2bf8e401476af1d7907b577e5f094d Gerrit-Change-Number: 41668 Gerrit-PatchSet: 2 Gerrit-Owner: falconia <falcon@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: falconia <falcon@freecalypso.org> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: pespin <pespin@sysmocom.de>