Attention is currently required from: fixeria. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/34517?usp=email ) Change subject: SMS over GSUP: correctly route GSUP responses to MT SMS ...................................................................... Patch Set 1: (2 comments) File src/libmsc/gsm_04_11.c: https://gerrit.osmocom.org/c/osmo-msc/+/34517/comment/8539858e_f6df51b5 PS1, Line 1258: talloc_size

FYI, you could use `talloc_memdup()` here: […] Noted, will change in the next iteration.

https://gerrit.osmocom.org/c/osmo-msc/+/34517/comment/e06c09a7_1f5bcefa PS1, Line 1260: msgb_free

IMO, this conditional block is a bit out of place here. […] Noted, will change in the next iteration.

-- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/34517?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I436e333035b8f6e27f86a49fe293ea48ea07a013 Gerrit-Change-Number: 34517 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <falcon@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Mon, 25 Sep 2023 03:16:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de> Gerrit-MessageType: comment