dexter has submitted this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/31802 ) Change subject: pcu_sock: use is_ericsson_bts() to check for ericsson BTS ...................................................................... pcu_sock: use is_ericsson_bts() to check for ericsson BTS Do not access bts->type directly, we have is_ericsson_bts() to do that Related: OS#5198 Change-Id: I274a9f0f1208dc17713ba2e1c7a1110eeb133cca --- M src/osmo-bsc/pcu_sock.c 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: fixeria: Looks good to me, approved pespin: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/src/osmo-bsc/pcu_sock.c b/src/osmo-bsc/pcu_sock.c index b6e626d..453d5a7 100644 --- a/src/osmo-bsc/pcu_sock.c +++ b/src/osmo-bsc/pcu_sock.c @@ -573,7 +573,7 @@ * assign downlink TBFs directly through the paging channel. However, this method never became part * of the RSL specs. This means that each BTS vendor has to come up with a proprietary method. At * the moment we only support Ericsson RBS here. */ - if (bts->type == GSM_BTS_TYPE_RBS2000) { + if (is_ericsson_bts(bts)) { rc = rsl_ericsson_imm_assign_cmd(bts, pch_dt->tlli, sizeof(pch_dt->data), pch_dt->data, pag_grp); } else { -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/31802 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I274a9f0f1208dc17713ba2e1c7a1110eeb133cca Gerrit-Change-Number: 31802 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-MessageType: merged