Attention is currently required from: dexter, jolly. pespin has posted comments on this change by dexter. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43144?usp=email ) Change subject: library/euicc: add ESipa JSON encoder/decoder module ...................................................................... Patch Set 4: (1 comment) File eim/eIM_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43144/comment/6ea65be1_ba3ba... : PS4, Line 441: esipa_res := dec_EsipaMessageFromEimToIpa(response_http.response_binary.body); Isn't it enough o move the "if (mp_esipa_json == true)" here? or do: if (ispresent(response_http.response_binary)) { if (mp_esipa_json) { fail() } .... } else if (ispresent(response_http.response)) { if (not mp_esipa_json) { fail() } .... } else { fail() -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/43144?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I8b6a87f39ca23658d980d19cf257b8994ea1cecb Gerrit-Change-Number: 43144 Gerrit-PatchSet: 4 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: jolly <andreas@eversberg.eu> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: jolly <andreas@eversberg.eu> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Fri, 07 Aug 2026 14:35:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No