Attention is currently required from: dexter, laforge, lynxis lazus.
Hoernchen has posted comments on this change by Hoernchen. ( https://gerrit.osmocom.org/c/pysim/+/43136?usp=email )
Change subject: GP: mixed PSK TLS PUT KEY (Amendment B Table 3-13)
......................................................................
Patch Set 3:
(1 comment)
File pySim/global_platform/__init__.py:
https://gerrit.osmocom.org/c/pysim/+/43136/comment/d555b5f2_73e2cf0f?usp=ema... :
PS1, Line 655: (b'\x85' + bertlv_encode_len(len(block)) + block +
: bytes([len(kcv)]) + kcv)
Yes, this should definitely handled by a construct definition.
Done
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/43136?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I480a9d049a052aa5ae54fe6e2771dba44e89434d
Gerrit-Change-Number: 43136
Gerrit-PatchSet: 3
Gerrit-Owner: Hoernchen
ewild@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter
pmaier@sysmocom.de
Gerrit-Reviewer: laforge
laforge@osmocom.org
Gerrit-Reviewer: lynxis lazus
lynxis@fe80.eu
Gerrit-Attention: laforge
laforge@osmocom.org
Gerrit-Attention: lynxis lazus
lynxis@fe80.eu
Gerrit-Attention: dexter
pmaier@sysmocom.de
Gerrit-Comment-Date: Mon, 10 Aug 2026 18:46:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge
laforge@osmocom.org
Comment-In-Reply-To: dexter
pmaier@sysmocom.de