pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33995 )
Change subject: pcu: Split f_ms_tx_ul_data_block() into helper functions
......................................................................
Patch Set 1:
(1 comment)
File pcu/GPRS_Components.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33995/comment/f04ec889_11e8…
PS1, Line 672: blocks
Why "blocks" (plural), btw? I see this
function is sending exactly one RLC/MAC block. […]
this function is not sending
exactly one block. It's sending a record of LlcBlocks, because an RLC/MAC block can
transport more than 1 LlcBlocks (or segments of them).
Another topic is that so far we only call this function to submit 1 Llc block because we
don't need sending more for simplicity (there's some test which validates sending
several llc blocks in one Rlc/MAC block iirc, and it may be possible to move it to use
this API, but that would be another patch which is not really high prio).
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/33995
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I81176fa5c7caa2535bcc97eec26833579933ed7a
Gerrit-Change-Number: 33995
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Mon, 31 Jul 2023 09:14:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment