Attention is currently required from: osmith.
msuraev has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30715 )
Change subject: rate counter: add StatsD note
......................................................................
Patch Set 2:
(5 comments)
File common/chapters/counters-overview.adoc:
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30715/comment/7130cc92_ff94…
PS2, Line 127: does
please use the same max line height as the rest of the
file, it seems to be < 80 characters
The agreed upon limit is 120 which is way
more convenient than 80.
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30715/comment/285fe48e_cb69…
PS2, Line 129: StatsD
* throughout the file it's written as
"statsd" […]
The rest of the file can be fixed in a separate commit
(unless we're talking about the name of the binary).
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30715/comment/470854c1_41de…
PS2, Line 130: Netdata
the Netdata dashboard
Done
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30715/comment/d70eb2c6_cb28…
PS2, Line 130: via
maybe add a colon at the end, so it's a full
sentence? "via:" […]
Done
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30715/comment/4d469c3c_6fe8…
PS2, Line 131: statsD isavailable
statsd is available
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-gsm-manuals/+/30715
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Change-Id: I124503c3707bbe005abbfb4245abe2829c6ff57c
Gerrit-Change-Number: 30715
Gerrit-PatchSet: 2
Gerrit-Owner: msuraev <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Fri, 23 Dec 2022 17:48:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment