Attention is currently required from: wbokslag. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/33997 ) Change subject: Added keyfile parsing code and various crypto improvements ...................................................................... Patch Set 2: (1 comment) File src/tetra-rx.c: https://gerrit.osmocom.org/c/osmo-tetra/+/33997/comment/4feb8f43_2f5936f7 PS2, Line 96: talloc again, just FYI: talloc is hieararchical. If one would pass the tetra_mac_state as context pointer when allocationg the tcs (instead of NULL as you're doing), then talloc_free(tms) would automatically free the tcs. -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/33997 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I1c7afeeb2dcf97ece44bb4b604f44ba88882b93f Gerrit-Change-Number: 33997 Gerrit-PatchSet: 2 Gerrit-Owner: wbokslag <w.bokslag@midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: wbokslag <w.bokslag@midnightblue.nl> Gerrit-Comment-Date: Sat, 29 Jul 2023 08:25:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment