Attention is currently required from: pespin.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641?usp=email )
Change subject: SIP_Emulation: Rename component id
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641/comment/d448a0d6_2e86…
PS1, Line 9: it makes it impossible to reference the
: component name under TESTPORT_PARAMETERS
I run `git-grep` and found this:
```
msc/MSC_Tests.default:[TESTPORT_PARAMETERS]
msc/MSC_Tests.default-"MSC_Test-MNCC".MNCC.socket_type :=
"SEQPACKET";
```
So escaping dashes should not be a problem.
We follow this naming style in other testcases. so I would suggest to stick to it.
File library/SIP_Emulation.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641/comment/58aa9a96_0341…
PS1, Line 229: _EMU
We also don't have the `EMU` in other emulation components, so why making this
different...
--
To view, visit
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36641?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Iecefe7d98a5842872f1efc55e013f672186ef1a8
Gerrit-Change-Number: 36641
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 25 Apr 2024 17:32:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment