Attention is currently required from: pespin, dexter. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/33546 ) Change subject: ASCI: Add new mode for voice group/broadcast call ...................................................................... Patch Set 2: (3 comments) Commit Message: https://gerrit.osmocom.org/c/osmo-mgw/+/33546/comment/48d525e5_6e735452 PS1, Line 19: Because there is no transcoding within the endpoint, only one connection

I'm not getting this paragraph. […] Changed the description.

File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/33546/comment/e4a9dc66_b2c10984 PS1, Line 1091: && (conn->conn->mode & MGCP_CONN_SEND_ONLY)

I'm not a big fan of reusing the flags for the SEND_ONLY for CONFECHO mode here, it makes stuff diff […] Due to reworking this change is not required anymore.

File tests/mgcp/mgcp_test.c: https://gerrit.osmocom.org/c/osmo-mgw/+/33546/comment/d77dd5a6_ea4a4c0b PS1, Line 715: /* Check that LOOPBACK disables all output */

I have the feeling you are presenting 2 patches in one here. […] Due to reworking this change is not required anymore.

-- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/33546 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I0639c663e119d85bef1010c7aa45e2f133a9daf0 Gerrit-Change-Number: 33546 Gerrit-PatchSet: 2 Gerrit-Owner: jolly <andreas@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-CC: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Attention: dexter <pmaier@sysmocom.de> Gerrit-Comment-Date: Mon, 10 Jul 2023 08:14:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment