dexter has submitted this change. ( https://gerrit.osmocom.org/c/onomondo-eim/+/43451?usp=email ) Change subject: esipa_asn_handler: add TODO about missing TLS / SNI support ...................................................................... esipa_asn_handler: add TODO about missing TLS / SNI support SGP.32 requires an eIM to support SNI, however since this eIM has no multi tenant support at all, it may not benefit much from this feature at the moment. However, according to the cowboy documentation SNI is supported and the effort to integrate it is manageable. Let's postpone this until we add multi tenant support. Related: SYS#8100 Change-Id: Iaebe29563259ae5fabeb9825839a03062d7fc24d --- M src/onomondo_eim_app.erl 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins Builder: Verified dexter: Looks good to me, approved diff --git a/src/onomondo_eim_app.erl b/src/onomondo_eim_app.erl index 89ffd4a..c5ea149 100644 --- a/src/onomondo_eim_app.erl +++ b/src/onomondo_eim_app.erl @@ -31,6 +31,9 @@ [InterfaceName, Ip, Port, Cert, Key] ), + % TODO: GSMA SGP.32, section 2.6.5 requires an eIM to support the SNI TLS extension. However, this eIM + % implementation still lacks SNI support. The effort required to add SNI support should be manageable as Cowboy + % offers SNI support (sni_fun). cowboy:start_tls( https_listener_esipa, [ -- To view, visit https://gerrit.osmocom.org/c/onomondo-eim/+/43451?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: onomondo-eim Gerrit-Branch: master Gerrit-Change-Id: Iaebe29563259ae5fabeb9825839a03062d7fc24d Gerrit-Change-Number: 43451 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org>