Change in libosmocore[master]: Introduce netdev API
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/31062 ) Change subject: Introduce netdev API ...................................................................... Patch Set 2: Code-Review+1 (2 comments) File include/osmocom/core/netdev.h: https://gerrit.osmocom.org/c/libosmocore/+/31062/comment/4b299be1_59cdbd99 PS2, Line 31: unsigned AFAICT, in the kernel, an ifindex is always of type "int", not "unsigned int". File src/core/netdev.c: https://gerrit.osmocom.org/c/libosmocore/+/31062/comment/2c65560c_668364bf PS2, Line 720: unsigned if we used a signed int for ifindex, we could return a negative error value here if no ifindex was set yet? -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/31062 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I7a00c0445a89e088676a4897061b65196d9197f1 Gerrit-Change-Number: 31062 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 24 Jan 2023 17:41:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
participants (1)
-
laforge